add support for /tl:[auto|on|off] msbuild flag #2768
Conversation
|
tried it (specificying
|
smoothdeveloper
force-pushed
the
msbuild-terminallogger-flag
branch
from
25ce9f1
to
545a1d2
Compare
|
now with |
xperiandri
force-pushed
the
msbuild-terminallogger-flag
branch
from
545a1d2
to
effc697
Compare
|
Do you have any ideas why build fails? |
|
@xperiandri no, I see the same on another run on master branch: https://github.com/fsprojects/FAKE/actions/runs/7174371576/job/19535683031 We should investigate but I doubt it is related to this change. |
|
Probably something bad with an agent. Maybe update the version of image |
xperiandri
force-pushed
the
msbuild-terminallogger-flag
branch
from
effc697
to
558d9a2
Compare
|
Could you rebase onto the latest master? |
smoothdeveloper
force-pushed
the
msbuild-terminallogger-flag
branch
from
558d9a2
to
ffe3452
Compare
|
@xperiandri not sure what is blocking in CI, seems an upload is timing out. |
xperiandri
force-pushed
the
msbuild-terminallogger-flag
branch
from
ffe3452
to
92b3f29
Compare
|
@smoothdeveloper do we need to update the release notes? |
|
Seems, good to me: a small addition, and there is no new dependencies or anything added. And release notes are there already updated in this PR. |
|
Is there any manually managed documentation for features like this, or is it just generated out of the XML doc comments? |
|
Conflict appeared |
Good point, thanks! Co-authored-by: Andrii Chebukin <[email protected]>
Co-authored-by: Andrii Chebukin <[email protected]>
smoothdeveloper
force-pushed
the
msbuild-terminallogger-flag
branch
from
92b3f29
to
21c36de
Compare
Description
see
--tl:[auto|on|off]ondotnet builddocumentation: https://learn.microsoft.com/en-gb/dotnet/core/tools/dotnet-buildSince this only works with dotnet sdk >= 8, the default case (specifying
Auto) will not emit the tag.TODO
Feel free to open the PR and ask for help
New (API-)documentation for new features exist (Note: API-docs are enough, additional docs are in
help/markdown)unit or integration test exists (or short reasoning why it doesn't make sense)
boy scout rule: "leave the code behind in a better state than you found it" (fix warnings, obsolete members or code-style in the places you worked in)
(if new module) the module has been linked from the "side navigation" menu, edit
docs/data.json.(if new module) the module is in the correct namespace.
(if new module) the module is added to Fake.sln (
dotnet sln Fake.sln add src/app/Fake.*/Fake.*.fsproj)Fake API guideline is honored